Use public key to validate access to the cloud templates#1619
Merged
MarceloRGonc merged 17 commits intomainfrom Nov 18, 2025
Merged
Use public key to validate access to the cloud templates#1619MarceloRGonc merged 17 commits intomainfrom
MarceloRGonc merged 17 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces Frontegg client-based authentication with JWT public key verification for cloud template access. The change eliminates the need for client ID and API key configuration, simplifying the authentication flow by directly verifying JWT tokens using a public key.
Key Changes:
- Replaced Frontegg IdentityClient with direct JWT verification using a public key
- Removed deprecated Frontegg configuration flags (FRONTEGG_CLIENT_ID, FRONTEGG_APP_ID, FRONTEGG_API_KEY)
- Refactored authentication logic from async API calls to synchronous JWT verification
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/lib/flag/flag.ts | Removed FRONTEGG_CLIENT_ID and FRONTEGG_APP_ID enum values |
| packages/server/shared/src/lib/system/system-prop.ts | Replaced Frontegg client credentials with FRONTEGG_PUBLIC_KEY |
| packages/server/api/test/integration/cloud/cloud/cloud-auth.test.ts | Updated tests to verify JWT-based authentication instead of Frontegg client validation |
| packages/server/api/src/app/user-info/user-info.module.ts | Replaced Frontegg client initialization with public key configuration |
| packages/server/api/src/app/user-info/cloud-auth.ts | Replaced async Frontegg validation with synchronous JWT verification |
| packages/server/api/src/app/helper/allow-all-origins-hook-handler.ts | Extracted CORS hook handler into reusable module |
| packages/server/api/src/app/flow-template/cloud-template.controller.ts | Updated to use JWT verification and extracted CORS handler |
| packages/server/api/src/app/flags/flag.service.ts | Removed Frontegg client configuration flags from service |
| packages/react-ui/src/app/routes/cloud-connection/frontegg-setup.ts | Simplified Frontegg initialization to use tenant resolver instead of client/app IDs |
| packages/react-ui/src/app/routes/cloud-connection/cloud-logout-page.tsx | Updated to initialize Frontegg with only URL parameter |
| packages/react-ui/src/app/routes/cloud-connection/cloud-connection-page.tsx | Updated to initialize Frontegg with only URL parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…up.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
maor-rozenfeld
approved these changes
Nov 17, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes OPS-2983.
Used the test environment to test the approach
Also tested with a production cookie and the test environment.
After this merge, we need to merge this PR: https://github.com/openops-cloud/devops/pull/117 before the production deployment.