Allow disabling the host validation via env var#1637
Merged
maor-rozenfeld merged 1 commit intomainfrom Nov 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to disable host validation through an environment variable (ENABLE_HOST_VALIDATION). The change allows operators to bypass internal address checks when needed, likely for specific deployment scenarios or testing environments.
Key Changes:
- Added
ENABLE_HOST_VALIDATIONsystem property with a default value oftrue - Modified
validateHostfunction to check the environment variable before performing validation - Added test coverage for the new disable functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/server/shared/src/lib/system/system-prop.ts | Defines the new ENABLE_HOST_VALIDATION enum value |
| packages/server/shared/src/lib/system/system.ts | Sets the default value for host validation to true |
| packages/server/shared/src/lib/host-validation/index.ts | Implements the conditional validation logic based on the environment variable |
| packages/server/shared/test/host-validation/index.test.ts | Adds test cases for disabled validation and empty host scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
MarceloRGonc
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves OPS-3078.