Add a way to have multiple types of flags.#1641
Merged
MarceloRGonc merged 1 commit intomainfrom Nov 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a type alias OpenOpsFlag to enable future support for multiple flag types. Currently, OpenOpsFlag is an alias for FlagId, allowing the codebase to migrate to a more flexible flag typing system without changing existing functionality.
Key Changes:
- Added
OpenOpsFlagtype alias in the shared package - Updated
useFlaghook to acceptOpenOpsFlaginstead ofFlagId
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/shared/src/lib/flag/flag.ts | Exports new OpenOpsFlag type alias for FlagId |
| packages/react-ui/src/app/common/hooks/flags-hooks.ts | Updates useFlag parameter type to use OpenOpsFlag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
bigfluffycookie
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of OPS-3117.