Skip to content

Standardize top bar heights in the app#1725

Merged
ravikiranvm merged 2 commits intomainfrom
ops-3181a
Dec 4, 2025
Merged

Standardize top bar heights in the app#1725
ravikiranvm merged 2 commits intomainfrom
ops-3181a

Conversation

@ravikiranvm
Copy link
Copy Markdown
Contributor

Fixes OPS-3181.

Additional Notes

Screenshot 2025-12-03 at 6 57 47 PM

@linear
Copy link
Copy Markdown

linear Bot commented Dec 3, 2025

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 3, 2025

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ops-3181a

Comment @coderabbitai help to get the list of available commands and usage tips.

<div
className={cn(
'w-full flex items-center px-6 py-[18px] h-[60px] flex-shrink-0',
'w-full flex items-center px-6 py-[18px] h-[60px] flex-shrink-0 border-b',
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to match the other top bars and the alignment

@ravikiranvm ravikiranvm marked this pull request as ready for review December 3, 2025 13:29
Copilot AI review requested due to automatic review settings December 3, 2025 13:29
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes top bar heights across the application to a consistent 60px height, addressing visual inconsistencies in the UI.

  • Adjusted PageHeader height from 61px to 60px
  • Added minimum height constraint to AssistantTopBar with vertical centering
  • Reorganized border styling by moving border from navigation to header in the sidebar

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
packages/ui-components/src/components/page-primitives/page-header.tsx Changed height from 61px to 60px to match standard
packages/ui-components/src/components/assistant-ui/assistant-top-bar.tsx Added min-h-[60px] and justify-center for consistent height
packages/ui-components/src/components/sidebar/side-menu-header.tsx Added border-b to header component
packages/ui-components/src/components/sidebar/side-menu-navigation.tsx Removed border-t from navigation component

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/ui-components/src/components/assistant-ui/assistant-top-bar.tsx Outdated
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Dec 3, 2025

Greptile Overview

Greptile Summary

Standardized all top bar heights to 60px across the application and fixed border styling to prevent double borders between components.

  • Changed PageHeader from h-[61px] to h-[60px] for consistency
  • Added min-h-[60px] justify-center to AssistantTopBar for flexible height with vertical centering
  • Moved border from SideMenuNavigation (border-t) to SideMenuHeader (border-b) to eliminate duplicate border

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - simple CSS changes for UI consistency
  • All changes are purely CSS styling adjustments that standardize heights and fix border rendering. No logic changes, no breaking API changes, and the modifications follow existing patterns in the codebase.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
packages/ui-components/src/components/assistant-ui/assistant-top-bar.tsx 5/5 Added min-h-[60px] justify-center to standardize height with other top bars
packages/ui-components/src/components/page-primitives/page-header.tsx 5/5 Changed height from h-[61px] to h-[60px] for consistency
packages/ui-components/src/components/sidebar/side-menu-header.tsx 5/5 Added border-b to create consistent border styling with other headers
packages/ui-components/src/components/sidebar/side-menu-navigation.tsx 5/5 Removed border-t to eliminate duplicate border between header and navigation

Sequence Diagram

sequenceDiagram
    participant User
    participant App
    participant PageHeader
    participant SideMenuHeader
    participant SideMenuNavigation
    participant AssistantTopBar

    User->>App: Loads Application
    App->>PageHeader: Render with h-[60px]
    PageHeader-->>App: Consistent 60px height
    App->>SideMenuHeader: Render with h-[60px] + border-b
    SideMenuHeader-->>App: 60px height with bottom border
    App->>SideMenuNavigation: Render without border-t
    Note over SideMenuHeader,SideMenuNavigation: Single border between header and navigation
    SideMenuNavigation-->>App: Navigation items displayed
    User->>App: Opens Assistant
    App->>AssistantTopBar: Render with min-h-[60px] + justify-center
    AssistantTopBar-->>App: Minimum 60px height, vertically centered
    Note over PageHeader,AssistantTopBar: All top bars standardized to 60px height
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@ravikiranvm ravikiranvm requested a review from rmn-snpk December 3, 2025 13:33
Comment thread packages/ui-components/src/components/page-primitives/page-header.tsx Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 4, 2025

@ravikiranvm ravikiranvm requested a review from rmn-snpk December 4, 2025 07:07
@ravikiranvm ravikiranvm merged commit 96a7281 into main Dec 4, 2025
24 checks passed
@ravikiranvm ravikiranvm deleted the ops-3181a branch December 4, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants