Skip to content

Add helper method to ensure benchmark folder existency#2011

Merged
ravikiranvm merged 8 commits intomainfrom
ops-3752
Feb 26, 2026
Merged

Add helper method to ensure benchmark folder existency#2011
ravikiranvm merged 8 commits intomainfrom
ops-3752

Conversation

@ravikiranvm
Copy link
Copy Markdown
Contributor

@ravikiranvm ravikiranvm commented Feb 25, 2026

Fixes OPS-3752

Additional Notes

This PR implements minimal service for create benchmark endpoint that ensures Benchmark folder exists for a given provider.

Also add a new method in folder service that checks for a folder and creates one.

@linear
Copy link
Copy Markdown

linear Bot commented Feb 25, 2026

@ravikiranvm ravikiranvm marked this pull request as ready for review February 25, 2026 11:25
Copilot AI review requested due to automatic review settings February 25, 2026 11:25
@ravikiranvm ravikiranvm changed the title Add helper method to ensure benchmark folder Add helper method to ensure benchmark folder existency Feb 25, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a small benchmark service layer to ensure a provider-specific benchmark folder exists (creating it if necessary), and introduces unit tests for the new behavior. This fits into the existing benchmark feature area alongside the wizard/provider adapters.

Changes:

  • Added getBenchmarkFolderDisplayName, ensureBenchmarkFolder, and createBenchmark in the benchmark service layer.
  • Added unit tests covering provider display name resolution, folder ensure behavior, and basic createBenchmark response shape.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/server/api/src/app/benchmark/create-benchmark.service.ts Introduces helper(s) to resolve benchmark folder name, ensure the folder exists via flowFolderService, and build a CreateBenchmarkResponse.
packages/server/api/test/unit/benchmark/create-benchmark.service.test.ts Adds unit coverage for provider handling and folder creation/reuse behavior via mocked flowFolderService.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/server/api/src/app/benchmark/create-benchmark.service.ts Outdated
Comment thread packages/server/api/test/unit/benchmark/create-benchmark.service.test.ts Outdated
Comment thread packages/server/api/src/app/benchmark/create-benchmark.service.ts Outdated
Comment thread packages/server/api/src/app/benchmark/create-benchmark.service.ts Outdated
Comment thread packages/server/api/src/app/benchmark/create-benchmark.service.ts
@sonarqubecloud
Copy link
Copy Markdown

@ravikiranvm ravikiranvm merged commit bd1d844 into main Feb 26, 2026
21 checks passed
@ravikiranvm ravikiranvm deleted the ops-3752 branch February 26, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants