Add helper method to ensure benchmark folder existency#2011
Merged
ravikiranvm merged 8 commits intomainfrom Feb 26, 2026
Merged
Add helper method to ensure benchmark folder existency#2011ravikiranvm merged 8 commits intomainfrom
ravikiranvm merged 8 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a small benchmark service layer to ensure a provider-specific benchmark folder exists (creating it if necessary), and introduces unit tests for the new behavior. This fits into the existing benchmark feature area alongside the wizard/provider adapters.
Changes:
- Added
getBenchmarkFolderDisplayName,ensureBenchmarkFolder, andcreateBenchmarkin the benchmark service layer. - Added unit tests covering provider display name resolution, folder ensure behavior, and basic
createBenchmarkresponse shape.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/server/api/src/app/benchmark/create-benchmark.service.ts | Introduces helper(s) to resolve benchmark folder name, ensure the folder exists via flowFolderService, and build a CreateBenchmarkResponse. |
| packages/server/api/test/unit/benchmark/create-benchmark.service.test.ts | Adds unit coverage for provider handling and folder creation/reuse behavior via mocked flowFolderService. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
MarceloRGonc
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes OPS-3752
Additional Notes
This PR implements minimal service for create benchmark endpoint that ensures Benchmark folder exists for a given provider.
Also add a new method in folder service that checks for a folder and creates one.