Skip to content

Remove unused dependencies and use static versions#2021

Merged
MarceloRGonc merged 12 commits intomainfrom
dependabot/clean-packages
Feb 27, 2026
Merged

Remove unused dependencies and use static versions#2021
MarceloRGonc merged 12 commits intomainfrom
dependabot/clean-packages

Conversation

@MarceloRGonc
Copy link
Copy Markdown
Contributor

@MarceloRGonc MarceloRGonc commented Feb 26, 2026

Fixes OPS-3796.

Additional Notes

  • Using static version for the dependencies
  • Remove unused ones

@MarceloRGonc MarceloRGonc marked this pull request as ready for review February 26, 2026 18:18
Copilot AI review requested due to automatic review settings February 26, 2026 18:18
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR tightens dependency management by pinning several packages to exact versions and removing unused Angular/Karma-related tooling from the Nx workspace.

Changes:

  • Pin previously ranged dependencies (e.g., ^x.y.z) to exact versions in package.json and sync package-lock.json.
  • Remove unused Karma/Jasmine-related dependencies and delete the karma.conf.js file.
  • Simplify nx.json by removing Karma/Angular-specific cache inputs and generator defaults.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
package.json Pins several dependencies to exact versions and removes Karma/Jasmine-related dev deps.
package-lock.json Regenerated/updated lockfile to reflect the new pinned versions and removed packages.
nx.json Removes references to karma.conf.js and Angular-specific Nx target/generator configuration.
karma.conf.js Deletes the Karma configuration file (no longer used).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json
Comment on lines 316 to 320
"@nx/js": "20.5.0",
"@nx/node": "19.8.8",
"@nx/react": "20.5.0",
"@nx/storybook": "^20.0.8",
"@nx/storybook": "20.8.4",
"@nx/vite": "19.8.8",
Copy link

Copilot AI Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nx/storybook is pinned to 20.8.4 while several other @nx/* packages (and the top-level nx install) are at 19.8.8 / 20.5.0. In the lockfile this results in multiple Nx copies being installed (e.g., @nx/storybook brings its own @nx/devkit/nx 20.8.4), which can lead to subtle plugin/runtime incompatibilities and larger installs. Consider aligning all @nx/* (and nx) packages to a single Nx release line/version to keep the toolchain consistent.

Copilot uses AI. Check for mistakes.
@linear
Copy link
Copy Markdown

linear Bot commented Feb 26, 2026

@sonarqubecloud
Copy link
Copy Markdown

@MarceloRGonc MarceloRGonc merged commit 4ca9b82 into main Feb 27, 2026
21 checks passed
@MarceloRGonc MarceloRGonc deleted the dependabot/clean-packages branch February 27, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants