Skip to content

Add security policy to benchmark endpoints#2115

Merged
MarceloRGonc merged 2 commits intomainfrom
mg/OPS-3898
Mar 12, 2026
Merged

Add security policy to benchmark endpoints#2115
MarceloRGonc merged 2 commits intomainfrom
mg/OPS-3898

Conversation

@MarceloRGonc
Copy link
Copy Markdown
Contributor

Fixes OPS-3898.

Copilot AI review requested due to automatic review settings March 12, 2026 11:05
@linear
Copy link
Copy Markdown

linear Bot commented Mar 12, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds/adjusts route-level security policies for benchmark-related API endpoints and refines folder/flow listing permissions to better reflect the data returned by those endpoints (OPS-3898).

Changes:

  • Added getProjectScopedRoutePolicy security policies to benchmark routes (list, wizard, create, status).
  • Updated folder “list folders + flows” route to require both folder and flow read permissions.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
packages/server/api/src/app/flows/folder/folder.module.ts Tightens access policy for listing folders along with their associated flows.
packages/server/api/src/app/benchmark/benchmark.controller.ts Introduces project-scoped security policies and required permissions for benchmark endpoints.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread packages/server/api/src/app/benchmark/benchmark.controller.ts
Comment thread packages/server/api/src/app/benchmark/benchmark.controller.ts
Comment thread packages/server/api/src/app/benchmark/benchmark.controller.ts
Comment thread packages/server/api/src/app/benchmark/benchmark.controller.ts
@sonarqubecloud
Copy link
Copy Markdown

@MarceloRGonc MarceloRGonc merged commit 64b49db into main Mar 12, 2026
21 checks passed
@MarceloRGonc MarceloRGonc deleted the mg/OPS-3898 branch March 12, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants