Skip to content

Add bypass host validation specifically for internal webhook URL#2195

Merged
MarceloRGonc merged 1 commit intomainfrom
mg/OPS-4071
Apr 2, 2026
Merged

Add bypass host validation specifically for internal webhook URL#2195
MarceloRGonc merged 1 commit intomainfrom
mg/OPS-4071

Conversation

@MarceloRGonc
Copy link
Copy Markdown
Contributor

Fixes OPS-4071

Copilot AI review requested due to automatic review settings April 2, 2026 14:39
@linear
Copy link
Copy Markdown

linear Bot commented Apr 2, 2026

@MarceloRGonc MarceloRGonc changed the title WIP Add bypass host validation specifically for internal webhook URL Apr 2, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 2, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an exception to host validation to allow calling the instance’s public webhook sync endpoint (even if it resolves to a private IP), addressing OPS-4071.

Changes:

  • Introduces validateHostAllowingPublicWebhookUrl in server-shared host validation.
  • Updates HTTP block “Send HTTP request” action to use the new validation helper.
  • Adds unit tests covering the webhook exception behavior.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/server/shared/test/host-validation/index.test.ts Adds tests for validateHostAllowingPublicWebhookUrl, including webhook-URL exception cases.
packages/server/shared/src/lib/host-validation/index.ts Implements validateHostAllowingPublicWebhookUrl using networkUtls.getPublicUrl() and a webhook URL regex.
packages/blocks/http/src/lib/actions/send-http-request-action.ts Switches validation to validateHostAllowingPublicWebhookUrl for request URL and proxy host.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/server/shared/src/lib/host-validation/index.ts
Comment thread packages/server/shared/src/lib/host-validation/index.ts
Comment thread packages/blocks/http/src/lib/actions/send-http-request-action.ts
@MarceloRGonc MarceloRGonc merged commit 3e412e9 into main Apr 2, 2026
25 checks passed
@MarceloRGonc MarceloRGonc deleted the mg/OPS-4071 branch April 2, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants