Add bypass host validation specifically for internal webhook URL#2195
Merged
MarceloRGonc merged 1 commit intomainfrom Apr 2, 2026
Merged
Add bypass host validation specifically for internal webhook URL#2195MarceloRGonc merged 1 commit intomainfrom
MarceloRGonc merged 1 commit intomainfrom
Conversation
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an exception to host validation to allow calling the instance’s public webhook sync endpoint (even if it resolves to a private IP), addressing OPS-4071.
Changes:
- Introduces
validateHostAllowingPublicWebhookUrlin server-shared host validation. - Updates HTTP block “Send HTTP request” action to use the new validation helper.
- Adds unit tests covering the webhook exception behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/server/shared/test/host-validation/index.test.ts | Adds tests for validateHostAllowingPublicWebhookUrl, including webhook-URL exception cases. |
| packages/server/shared/src/lib/host-validation/index.ts | Implements validateHostAllowingPublicWebhookUrl using networkUtls.getPublicUrl() and a webhook URL regex. |
| packages/blocks/http/src/lib/actions/send-http-request-action.ts | Switches validation to validateHostAllowingPublicWebhookUrl for request URL and proxy host. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ravikiranvm
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes OPS-4071