Allow internal webhook call on the HTTP action on local dev environment#2213
Merged
MarceloRGonc merged 7 commits intomainfrom Apr 10, 2026
Merged
Allow internal webhook call on the HTTP action on local dev environment#2213MarceloRGonc merged 7 commits intomainfrom
MarceloRGonc merged 7 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the HTTP block’s webhook URL validation/rewriting logic so that, when a user provides a “public” webhook sync URL that fails internal-host validation (common in local dev), it can be rewritten to the configured internal API base URL while handling base-path variations more robustly.
Changes:
- Refactors
validateAndRewritePublicWebhookUrlto normalize/strip base paths and extract the webhook sync route before rewriting. - Expands unit tests into parameterized cases covering more public/internal base-path combinations and trailing slash scenarios.
- Preserves query string and hash when rewriting to the internal API URL.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/blocks/http/src/lib/common/webhook-url-validator.ts | Adds base-path normalization/extraction helpers and rewrites matching webhook sync URLs to the internal API URL (including search/hash). |
| packages/blocks/http/test/webhook-url-validator.test.ts | Converts rewrite/throw tests to test.each with broader coverage of base-path and slash combinations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
ravikiranvm
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes OPS-4101