Skip to content

Modify some EBS and RDS actions to allow partial results#2220

Merged
ravikiranvm merged 7 commits intomainfrom
ops-4065b
Apr 16, 2026
Merged

Modify some EBS and RDS actions to allow partial results#2220
ravikiranvm merged 7 commits intomainfrom
ops-4065b

Conversation

@ravikiranvm
Copy link
Copy Markdown
Contributor

@ravikiranvm ravikiranvm commented Apr 14, 2026

Part of OPS-4065.

AWS Actions being modified in this PR:

  1. RDS Get Instances
  2. RDS Get Snapshots
  3. EBS Get Volumes

I will open another PR for Compute Optimiser actions.

Additional Notes

Screenshot 2026-04-15 at 11 30 35 AM Screenshot 2026-04-15 at 11 30 26 AM Screenshot 2026-04-15 at 11 30 20 AM

@linear
Copy link
Copy Markdown

linear bot commented Apr 14, 2026

@ravikiranvm ravikiranvm marked this pull request as ready for review April 14, 2026 07:26
Copilot AI review requested due to automatic review settings April 14, 2026 07:26
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds “allow partial results” support to selected AWS EBS and RDS describe helpers/actions so workflows can return successful regional results while reporting which regions failed.

Changes:

  • Introduces a shared PartialResult / FailedRegion model and error formatter (partial-result.ts) and reuses it in existing EC2 code.
  • Adds new *AllowPartial helpers for RDS (instances/snapshots) and EBS volumes that use Promise.allSettled to collect successes + failed regions.
  • Extends AWS block actions (RDS instances/snapshots, EBS volumes) with an allowPartialResults checkbox to switch output shape to { results, failedRegions }.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
packages/openops/src/lib/aws/partial-result.ts New shared types/util for partial results and error formatting.
packages/openops/src/lib/aws/ec2/ec2-get-instances.ts Refactors to import partial-result types/util from the new shared module.
packages/openops/src/lib/aws/rds/rds-describe.ts Adds describeRds*AllowPartial APIs and refactors per-region fetch helpers.
packages/openops/src/lib/aws/ebs/get-ebs-volumes.ts Adds getEbsVolumesAllowPartial using settled promises and shared metadata model.
packages/openops/src/index.ts Re-exports the new partial-result module.
packages/blocks/aws/src/lib/actions/rds/rds-describe-snapshots-action.ts Adds allowPartialResults option and returns partial shape when enabled.
packages/blocks/aws/src/lib/actions/rds/rds-describe-instances-action.ts Adds allowPartialResults option and returns partial shape when enabled.
packages/blocks/aws/src/lib/actions/ebs/ebs-get-volumes-action.ts Adds allowPartialResults option and returns partial shape when enabled.
packages/openops/test/aws/rds/rds-describe.test.ts Adds unit tests for the new RDS allow-partial helpers.
packages/openops/test/aws/ebs/ebs-get-volumes.test.ts Adds unit tests for the new EBS allow-partial helper.
packages/blocks/aws/test/rds/rds-describe-snapshots-action.test.ts Updates action props expectations and adds allow-partial behavior tests.
packages/blocks/aws/test/rds/rds-describe-instances-action.test.ts Updates action props expectations and adds allow-partial behavior tests.
packages/blocks/aws/test/ebs/ebs-get-volumes-action.test.ts Updates action props expectations and adds allow-partial behavior tests.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/openops/src/lib/aws/rds/rds-describe.ts
Comment thread packages/openops/src/lib/aws/rds/rds-describe.ts Outdated
Comment thread packages/openops/src/lib/aws/rds/rds-describe.ts
Comment thread packages/openops/src/lib/aws/rds/rds-describe.ts Outdated
Comment thread packages/openops/src/lib/aws/rds/rds-describe.ts
Comment thread packages/openops/src/lib/aws/rds/rds-describe.ts
@sonarqubecloud
Copy link
Copy Markdown

@ravikiranvm ravikiranvm merged commit ef8e993 into main Apr 16, 2026
21 checks passed
@ravikiranvm ravikiranvm deleted the ops-4065b branch April 16, 2026 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants