add lunr search #907
Merged
add lunr search #907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #428
Here are a few comments that may affect the pull request’s approval:
Search Scope: Currently, search functionality is limited to a single hyperbook. There is no support for cross-search across a hyperlibrary.
Stemming: Stemming is only implemented for the English language at the moment. To improve stemming for other languages, we would need to standardize the language key in the hyperbook configuration and use it to load appropriate language models in Lunr (see Lunr Language Support Guide).
Keyword Highlighting: The search results do not currently highlight the searched keyword. For reference, this feature is implemented in this example.
Let me know if you'd like further clarification on any of these points, or if one of those is a showstopper for you.
Update: