fix: add mjs extensions to files #655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example Next.js was not able to determine the correct file by just looking at the package.json. Therefore we needed to add mjs to als esm modules, which is also recommended by Node. In this process we switched our build tool from tsc to esbuild to add the correct file-extension and to speed the process up.Because we now fully support esm the @emotion/styled package was not working anymore, thus we have reworked this too. Now everything should be working in CommonJS and ES-Modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example Next.js was not able to determine the correct file by just looking at the package.json. Therefore we needed to add mjs to als esm modules, which is also recommended by Node. In this process we switched our build tool from tsc to esbuild to add the correct file-extension and to speed the process up.
Because we now fully support esm the @emotion/styled package was not working anymore, thus we have reworked this too. Now everything should be working in CommonJS and ES-Modules.
There should be no effect on users of this library other than it is now working as expected as an esm.