Add numpy as req in setup.cfg #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been added in 0.3.0, with the compiling subpackage. It has been (and probably will be) fine as a transitive dependency from OpenPathSampling. But there's no reason to do best practices.
Member
Author
|
This is ready for review and comment. Without review, I will merge this after at least 12 hours, no sooner than Fri 09 Aug 18:00 GMT (13:00 my local). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 5422 5422
=========================================
Hits 5422 5422 ☔ View full report in Codecov by Sentry. |
sroet
approved these changes
Aug 9, 2024
Member
sroet
left a comment
sroet
left a comment
There was a problem hiding this comment.
nice catch by the analysis. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have been added in 0.3.0, with the compiling subpackage. It has been (and probably will be) fine as a transitive dependency from OpenPathSampling. But there's no reason not to do best practices.
See conda-forge/openpathsampling-cli-feedstock#7 (comment)