Skip to content

Conversation

@dwhswenson
Copy link
Member

This provides a CLI interface for the FullBootstrap initialization from OpenPathSampling core, which is used in the MSTIS/MISTIS OPS example notebooks.

@codecov
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6f0e2d6) to head (8352adc).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #88    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          112       114     +2     
  Lines         5534      5647   +113     
==========================================
+ Hits          5534      5647   +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dwhswenson dwhswenson added the enhancement New feature or request label Aug 27, 2024
@dwhswenson
Copy link
Member Author

This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Wed 28 Aug 12:00 GMT (14:00 my local).

Copy link
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one question about new parameter, feel free to ignore, LGTM otherwise

Comment on lines 112 to 120
MULTI_INIT_SNAP = OPSStorageLoadMultiple(
param=Option('-f', '--init-frame',
help="identifier for potential initial snapshots"),
store='snapshots',
value_strategies=[GetByName('tags'), GetByNumber('snapshots')],
none_strategies=[GetOnlySnapshot(),
GetPredefinedName('tags', 'initial_snapshot')]
)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually used somewhere?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No; the original idea in this branch was to write something that would be a single command to set up an entire network (which could require multiple initial snapshots). But that's a little too messy, and so I'd rather have the user set up one transition at a time.

Removed MULTI_INIT_SNAP in 8352adc.

@dwhswenson dwhswenson merged commit 02b3374 into openpathsampling:main Aug 30, 2024
@dwhswenson dwhswenson deleted the cmd-bootstrap-init branch August 30, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants