-
Notifications
You must be signed in to change notification settings - Fork 3
New command: bootstrap-init
#88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New command: bootstrap-init
#88
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 112 114 +2
Lines 5534 5647 +113
==========================================
+ Hits 5534 5647 +113 ☔ View full report in Codecov by Sentry. |
|
This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Wed 28 Aug 12:00 GMT (14:00 my local). |
sroet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one question about new parameter, feel free to ignore, LGTM otherwise
paths_cli/parameters.py
Outdated
| MULTI_INIT_SNAP = OPSStorageLoadMultiple( | ||
| param=Option('-f', '--init-frame', | ||
| help="identifier for potential initial snapshots"), | ||
| store='snapshots', | ||
| value_strategies=[GetByName('tags'), GetByNumber('snapshots')], | ||
| none_strategies=[GetOnlySnapshot(), | ||
| GetPredefinedName('tags', 'initial_snapshot')] | ||
| ) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually used somewhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No; the original idea in this branch was to write something that would be a single command to set up an entire network (which could require multiple initial snapshots). But that's a little too messy, and so I'd rather have the user set up one transition at a time.
Removed MULTI_INIT_SNAP in 8352adc.
This provides a CLI interface for the
FullBootstrapinitialization from OpenPathSampling core, which is used in the MSTIS/MISTIS OPS example notebooks.