Skip to content

clarify error message on missing units#1122

Merged
sroet merged 1 commit intoopenpathsampling:masterfrom
dwhswenson:fix-simtkunit-error-msg
Oct 12, 2022
Merged

clarify error message on missing units#1122
sroet merged 1 commit intoopenpathsampling:masterfrom
dwhswenson:fix-simtkunit-error-msg

Conversation

@dwhswenson
Copy link
Copy Markdown
Member

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2022

Codecov Report

Base: 81.75% // Head: 81.76% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6378f8e) compared to base (965d8a2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1122   +/-   ##
=======================================
  Coverage   81.75%   81.76%           
=======================================
  Files         142      142           
  Lines       15612    15612           
=======================================
+ Hits        12764    12765    +1     
+ Misses       2848     2847    -1     
Impacted Files Coverage Δ
openpathsampling/integration_tools.py 95.65% <100.00%> (ø)
openpathsampling/netcdfplus/cache.py 64.05% <0.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! merging

@sroet sroet merged commit d984cc1 into openpathsampling:master Oct 12, 2022
@dwhswenson dwhswenson deleted the fix-simtkunit-error-msg branch November 6, 2022 05:00
@dwhswenson dwhswenson mentioned this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants