Updates to Examples#798
Merged
dwhswenson merged 11 commits intoopenpathsampling:masterfrom Oct 6, 2018
Merged
Conversation
jhprinz
approved these changes
Oct 5, 2018
Contributor
jhprinz
left a comment
jhprinz
left a comment
There was a problem hiding this comment.
Besides the note on py3 / py2 looks good. I like the simplification in variables.
| "version": "3.6.1" | ||
| "pygments_lexer": "ipython2", | ||
| "version": "2.7.15" | ||
| } |
Contributor
There was a problem hiding this comment.
I think this change from python 3 to 2 should not matter, right? These notebooks should be compatible with both anyway...
Member
Author
There was a problem hiding this comment.
This changes to whatever you used the last time you saved the notebooks. I was in Py 2.7 when I made the updates here. But these notebooks are run in our test suite, so as long as tests pass, they must work with both Python 2 and 3!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes several updates I've made to the examples, most significantly a bunch of changes that make some examples match the papers better.
This also includes #768. (Although I don't think that problem is fully solved.)
This should be merged soon, since these changes were mentioned in our response to the reviewers.