Skip to content

Conversation

@jthompson-arcus
Copy link
Collaborator

No description provided.

@LDSamson
Copy link
Collaborator

LDSamson commented Apr 2, 2025

@jthompson-arcus I had no issues running renv::restore (but it was using my local cache)..

These changes are cleaner than the ones I proposed, so if it works on @aclark02-arcus pc, I would be fine to merge it.
Maybe a version bump/news update can still be added.

Also fixed the R version in the pkgdown workflow, as discussed (see issue RcppCore/Rcpp#1341)

@jthompson-arcus
Copy link
Collaborator Author

@aclark02-arcus can you run renv::restore() on this branch and see if it updates locally for you with no issue?

@LDSamson LDSamson mentioned this pull request Apr 2, 2025
@LDSamson
Copy link
Collaborator

LDSamson commented Apr 3, 2025

If I remember correcly, I think @aclark02-arcus did not have time to look at this before Friday.

Therefore I tested it on a separate PC, after deleting the renv cache. All packages installed correctly, no packages were installed from source, and the tests ran without problems. Therefore, I am quite confident that this works now and I think we can merge it.

@LDSamson LDSamson marked this pull request as ready for review April 3, 2025 07:46
@LDSamson LDSamson merged commit 948edc6 into dev Apr 3, 2025
5 checks passed
@LDSamson LDSamson deleted the jt-update_chromote branch April 3, 2025 07:47
@aclark02-arcus
Copy link
Collaborator

Hi all, just to confirm, I was able to run renv::restore() successfully on dev since the jt-update_chromote branch has been deleted. 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants