fix: Modify overview query for different role#438
Merged
Conversation
whDongRui
commented
Sep 29, 2018
whDongRui
commented
Contributor
- fix: Modify meun styles
* fix: Modify meun styles
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
=======================================
Coverage 17.69% 17.69%
=======================================
Files 86 86
Lines 1373 1373
Branches 286 286
=======================================
Hits 243 243
Misses 1075 1075
Partials 55 55
Continue to review full report at Codecov.
|
sunnywx
reviewed
Sep 29, 2018
| isDev: userInfo.role === 'developer', | ||
| isNormal: userInfo.role === 'user', | ||
| loginTime: new Date() | ||
| loginTime: Date.parse(new Date()) |
Contributor
Author
There was a problem hiding this comment.
ok. Modify Date.now().
sunnywx
reviewed
Sep 29, 2018
| @@ -20,46 +22,43 @@ export default class RepoList extends PureComponent { | |||
|
|
|||
| static defaultProps = { | |||
| type: 'public', | |||
Contributor
There was a problem hiding this comment.
default type not in range of prop-types
Contributor
Author
There was a problem hiding this comment.
ok, default "repo"
sunnywx
approved these changes
Sep 30, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.