Skip to content

add translations#22

Merged
microstudi merged 2 commits intomainfrom
extra-translations
Mar 5, 2026
Merged

add translations#22
microstudi merged 2 commits intomainfrom
extra-translations

Conversation

@microstudi
Copy link
Member

@microstudi microstudi commented Mar 5, 2026

Summary by CodeRabbit

  • New Features

    • Added a benchmarking analytics feature to compare participation data across multiple participatory spaces.
  • Localization

    • New translations for the benchmarking UI added in Catalan, German, and Spanish (menu titles, selection prompts, no-data messages, table and page labels).
    • French translations refined for clarity in benchmarking labels and several user field descriptions.

Copilot AI review requested due to automatic review settings March 5, 2026 14:42
@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

📝 Walkthrough

Walkthrough

Adds benchmarking localization keys to Catalan, German, and Spanish locale files and updates several French localization strings related to benchmarking, participant-type labels, NGO boolean label, and motto text. Changes are limited to i18n YAML files; no code or behavior changes.

Changes

Cohort / File(s) Summary
New benchmarking locales
config/locales/ca.yml, config/locales/de.yml, config/locales/es.yml
Adds a decidim.admin.exports.extra_user_fields.benchmarking subtree with keys: menu_title, no_data, select_spaces, select_spaces_prompt, table_label, and title.
French localization updates
config/locales/fr.yml
Refines decidim.admin.exports.extra_user_fields.benchmarking labels and updates several user-facing labels: boolean_fields.ngo, select_fields.participant_type (two occurrences), and text_fields.motto (two occurrences).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰
Traduccions salten com prats en flor,
Paraules noves per mesurar millor.
Català, Deutsch i Español s'han afegit,
Francès s’ha polid i tot queda dit.
Brinco, celebro aquest petit canvi amb honor!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'add translations' is vague and generic. While it is related to the changeset (the PR does add translations), it provides almost no meaningful information about what translations are being added or their purpose. Use a more descriptive title that specifies what feature or section is being translated, such as 'Add benchmarking feature translations for multiple languages' or 'Add translations for benchmarking analytics UI'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch extra-translations

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds and refines i18n strings for the ExtraUserFields admin “benchmarking” UI and improves French labels for several end-user registration/profile fields.

Changes:

  • Add missing decidim.admin.extra_user_fields.benchmarking.* translations for es, de, and ca.
  • Update fr benchmarking terminology (menu title and table label) to “Analyse comparative”.
  • Update fr end-user field labels (NGO, participant type, motto) to user-facing phrasing instead of admin “enable field” phrasing.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
config/locales/fr.yml Refines benchmarking wording and updates public-facing field labels.
config/locales/es.yml Adds missing admin benchmarking translation block.
config/locales/de.yml Adds missing admin benchmarking translation block.
config/locales/ca.yml Adds missing admin benchmarking translation block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@config/locales/de.yml`:
- Around line 193-194: Update the German translation string for the "underage"
key to correct the grammar by changing "unter %{limit} Jahre alt" to "unter
%{limit} Jahren alt" (or an equivalent grammatically correct phrase), ensuring
the interpolation variable %{limit} remains unchanged and the YAML
indentation/formatting for the underage key is preserved.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 931b882e-feab-4511-96bf-e2ec317d106e

📥 Commits

Reviewing files that changed from the base of the PR and between 1a6fdad and 055e8cc.

📒 Files selected for processing (3)
  • config/locales/de.yml
  • config/locales/es.yml
  • config/locales/fr.yml
🚧 Files skipped from review as they are similar to previous changes (2)
  • config/locales/fr.yml
  • config/locales/es.yml

Comment on lines +193 to +194
underage: Ich bin unter %{limit} Jahre alt und stimme zu, eine elterliche
Genehmigung einzuholen
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix German grammar in underage signup text.

Line 193 currently says unter %{limit} Jahre alt; this should be unter %{limit} Jahren alt (or an equivalent construction).

✏️ Proposed text fix
-          underage: Ich bin unter %{limit} Jahre alt und stimme zu, eine elterliche
+          underage: Ich bin unter %{limit} Jahren alt und stimme zu, eine elterliche
             Genehmigung einzuholen
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
underage: Ich bin unter %{limit} Jahre alt und stimme zu, eine elterliche
Genehmigung einzuholen
underage: Ich bin unter %{limit} Jahren alt und stimme zu, eine elterliche
Genehmigung einzuholen
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@config/locales/de.yml` around lines 193 - 194, Update the German translation
string for the "underage" key to correct the grammar by changing "unter %{limit}
Jahre alt" to "unter %{limit} Jahren alt" (or an equivalent grammatically
correct phrase), ensuring the interpolation variable %{limit} remains unchanged
and the YAML indentation/formatting for the underage key is preserved.

@microstudi microstudi merged commit b76f79a into main Mar 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants