Conversation
📝 WalkthroughWalkthroughAdds benchmarking localization keys to Catalan, German, and Spanish locale files and updates several French localization strings related to benchmarking, participant-type labels, NGO boolean label, and motto text. Changes are limited to i18n YAML files; no code or behavior changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Adds and refines i18n strings for the ExtraUserFields admin “benchmarking” UI and improves French labels for several end-user registration/profile fields.
Changes:
- Add missing
decidim.admin.extra_user_fields.benchmarking.*translations for es, de, and ca. - Update fr benchmarking terminology (menu title and table label) to “Analyse comparative”.
- Update fr end-user field labels (NGO, participant type, motto) to user-facing phrasing instead of admin “enable field” phrasing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| config/locales/fr.yml | Refines benchmarking wording and updates public-facing field labels. |
| config/locales/es.yml | Adds missing admin benchmarking translation block. |
| config/locales/de.yml | Adds missing admin benchmarking translation block. |
| config/locales/ca.yml | Adds missing admin benchmarking translation block. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@config/locales/de.yml`:
- Around line 193-194: Update the German translation string for the "underage"
key to correct the grammar by changing "unter %{limit} Jahre alt" to "unter
%{limit} Jahren alt" (or an equivalent grammatically correct phrase), ensuring
the interpolation variable %{limit} remains unchanged and the YAML
indentation/formatting for the underage key is preserved.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 931b882e-feab-4511-96bf-e2ec317d106e
📒 Files selected for processing (3)
config/locales/de.ymlconfig/locales/es.ymlconfig/locales/fr.yml
🚧 Files skipped from review as they are similar to previous changes (2)
- config/locales/fr.yml
- config/locales/es.yml
| underage: Ich bin unter %{limit} Jahre alt und stimme zu, eine elterliche | ||
| Genehmigung einzuholen |
There was a problem hiding this comment.
Fix German grammar in underage signup text.
Line 193 currently says unter %{limit} Jahre alt; this should be unter %{limit} Jahren alt (or an equivalent construction).
✏️ Proposed text fix
- underage: Ich bin unter %{limit} Jahre alt und stimme zu, eine elterliche
+ underage: Ich bin unter %{limit} Jahren alt und stimme zu, eine elterliche
Genehmigung einzuholen📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| underage: Ich bin unter %{limit} Jahre alt und stimme zu, eine elterliche | |
| Genehmigung einzuholen | |
| underage: Ich bin unter %{limit} Jahren alt und stimme zu, eine elterliche | |
| Genehmigung einzuholen |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@config/locales/de.yml` around lines 193 - 194, Update the German translation
string for the "underage" key to correct the grammar by changing "unter %{limit}
Jahre alt" to "unter %{limit} Jahren alt" (or an equivalent grammatically
correct phrase), ensuring the interpolation variable %{limit} remains unchanged
and the YAML indentation/formatting for the underage key is preserved.
Summary by CodeRabbit
New Features
Localization