Fix BLE notification properties and add missing ESC telemetry notifications#84
Closed
Copilot wants to merge 3 commits intoble-loggingfrom
Closed
Fix BLE notification properties and add missing ESC telemetry notifications#84Copilot wants to merge 3 commits intoble-loggingfrom
Copilot wants to merge 3 commits intoble-loggingfrom
Conversation
Closed
- Add NIMBLE_PROPERTY::NOTIFY to all ESC characteristics (voltage, current, RPM, temps) - Add notify() calls in updateESCTelemetryBLE() when device is connected - Ensures consistency with BMS service notification pattern Co-authored-by: zjwhitehead <4623792+zjwhitehead@users.noreply.github.com>
…e ESC service - Add NIMBLE_PROPERTY::NOTIFY to BMS telemetry characteristics (SOC, voltage, current, power, cells, temps, voltage diff) - Add ESC_TELEMETRY_SERVICE_UUID to BLE advertising for better discoverability - Ensures all characteristics that call notify() have proper NOTIFY property Co-authored-by: zjwhitehead <4623792+zjwhitehead@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update BLE architecture with logging improvements
Fix BLE notification properties and add missing ESC telemetry notifications
Jan 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The BLE implementation had inconsistencies between characteristic property declarations and actual notification behavior. ESC telemetry wasn't notifying clients of updates, and several BMS characteristics called
notify()without declaring theNOTIFYproperty.Fixed ESC Service Notifications:
NIMBLE_PROPERTY::NOTIFYto all ESC characteristics (voltage, current, RPM, temperatures)notify()calls inupdateESCTelemetryBLE()with connection checkESC_TELEMETRY_SERVICE_UUIDto BLE advertisingFixed BMS Service Property Declarations:
NIMBLE_PROPERTY::NOTIFYto telemetry characteristics that were already callingnotify()(SOC, voltage, current, power, cell voltages, temperatures, voltage differential)Before:
After:
All BLE characteristics now properly declare
NOTIFYwhen sending notifications, ensuring correct BLE protocol compliance and real-time telemetry updates.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.