Remove legacy BLE telemetry code#92
Conversation
Co-authored-by: zjwhitehead <4623792+zjwhitehead@users.noreply.github.com>
|
@copilot there aren't any BLE data that we are losing because of this legacy deprecation right? its all still there (even if its in a different format) |
Correct — no data is lost. Every field from the legacy individual characteristics is present in the packed V1 structs: BMS ( ESC ( The only change is structural: previously each value had its own BLE characteristic UUID that clients could subscribe to individually; now everything is delivered in a single binary-packed notification per update. Same data, more efficient transport. |
Legacy individual BLE characteristics were already default-disabled via
DISABLE_LEGACY_BLE_TELEMETRY. This removes the dead code entirely, leaving only the packed binary telemetry path (V1 protocol).Removed
updateBMSTelemetryandupdateESCTelemetryBLE— implementations, stubs, and declarations#ifndef DISABLE_LEGACY_BLE_TELEMETRYguards and their contents inbms_service.cpp/esc_service.cppble_ids.h-D DISABLE_LEGACY_BLE_TELEMETRYbuild flag fromplatformio.inible_utils.hinclude frombms_service.cpp(was only needed by legacy notify-on-change logic)sp140.ino✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.