Skip to content

Use codecov instead of coveralls#231

Merged
dburkhardt merged 3 commits intoopenproblems-bio:masterfrom
michalk8:bugfix/codecov
Mar 25, 2021
Merged

Use codecov instead of coveralls#231
dburkhardt merged 3 commits intoopenproblems-bio:masterfrom
michalk8:bugfix/codecov

Conversation

@michalk8
Copy link
Copy Markdown
Contributor

Submission type

  • This submission adds a new dataset
  • This submission adds a new method
  • This submission adds a new metric
  • This submission adds a new task
  • This submission adds a new Docker image
  • This submission fixes a bug (link to related issue: )
  • This submission adds a new feature not listed above

Testing

  • This submission was written on a forked copy of SingleCellOpenProblems
  • GitHub Actions "Run Benchmark" tests are passing on this base branch of this pull request (include link to passed test: )
  • If this pull request is not ready for review (including passing the "Run Benchmark" tests), I will open this PR as a draft (click on the down arrow next to the "Create Pull Request" button)

Submission guidelines

  • This submission follows the guidelines in our Contributing document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change

Following the discussion with @dburkhardt , this switched coveralls -> codecov in hopes to solve the coverage upload problems.

@dburkhardt dburkhardt self-requested a review March 25, 2021 14:11
@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@362b53d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #231   +/-   ##
=========================================
  Coverage          ?   95.92%           
=========================================
  Files             ?       68           
  Lines             ?     1399           
  Branches          ?       85           
=========================================
  Hits              ?     1342           
  Misses            ?       29           
  Partials          ?       28           
Flag Coverage Δ
unittests 95.92% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362b53d...7d25966. Read the comment docs.

@LuckyMD
Copy link
Copy Markdown
Collaborator

LuckyMD commented Mar 25, 2021

nice that tests are now passing :). I think @dburkhardt is just fixing the .version in the docker folder. And then this should be next up.

@LuckyMD
Copy link
Copy Markdown
Collaborator

LuckyMD commented Mar 25, 2021

@michalk8 I guess the S3 setup is failing in your fork as you don't have the AWS credentials yet?

@michalk8
Copy link
Copy Markdown
Contributor Author

@michalk8 I guess the S3 setup is failing in your fork as you don't have the AWS credentials yet?

Sort of - I have the credentials, I didn't set up them up yet (will do so now).

@dburkhardt dburkhardt merged commit 8e685cc into openproblems-bio:master Mar 25, 2021
rcannood pushed a commit that referenced this pull request Sep 4, 2024
* add images

* update changelog

* remove images from batch_integration

* remove images
rcannood pushed a commit that referenced this pull request Sep 4, 2024
* add images

* update changelog

* remove images from batch_integration

* remove images

Former-commit-id: e831819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants