Skip to content

set maxit on neuralee#403

Merged
scottgigante-immunai merged 1 commit intoopenproblems-bio:mainfrom
scottgigante-immunai:tests/neuralee_speedup
May 16, 2022
Merged

set maxit on neuralee#403
scottgigante-immunai merged 1 commit intoopenproblems-bio:mainfrom
scottgigante-immunai:tests/neuralee_speedup

Conversation

@scottgigante-immunai
Copy link
Copy Markdown
Collaborator

@scottgigante-immunai scottgigante-immunai commented May 13, 2022

NeuralEE takes ~10 minutes on test datasets. This should speed it up.

Submission type

  • This submission adds a new dataset
  • This submission adds a new method
  • This submission adds a new metric
  • This submission adds a new task
  • This submission adds a new Docker image
  • This submission fixes a bug (link to related issue: )
  • This submission adds a new feature not listed above

Testing

  • This submission was written on a forked copy of SingleCellOpenProblems
  • GitHub Actions "Run Benchmark" tests are passing on this base branch of this pull request (include link to passed test: https://github.com/scottgigante-immunai/openproblems/runs/6427901536?check_suite_focus=true)
  • If this pull request is not ready for review (including passing the "Run Benchmark" tests), I will open this PR as a draft (click on the down arrow next to the "Create Pull Request" button)

Submission guidelines

  • This submission follows the guidelines in our Contributing document
  • I have checked to ensure there aren't other open Pull Requests for the same update/change

PR review checklist

This PR will be evaluated on the basis of the following checks:

  • The task addresses a valid open problem in single-cell analysis
  • The latest version of master is merged and tested
  • The methods/metrics are imported to __init__.py and were tested in the pipeline
  • Method and metric decorators are annotated with paper title, year, author, code version, and date
  • The README gives an outline of the methods, metrics and datasets in the folder
  • The README provides a satisfactory task explanation (for new tasks)
  • The sample test data is appropriate to test implementation of all methods and metrics (for new tasks)

@scottgigante-immunai scottgigante-immunai marked this pull request as ready for review May 13, 2022 19:33
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2022

Codecov Report

Merging #403 (fd3204c) into main (457a12c) will decrease coverage by 0.04%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   91.91%   91.87%   -0.05%     
==========================================
  Files          89       89              
  Lines        2079     2079              
  Branches      119      120       +1     
==========================================
- Hits         1911     1910       -1     
  Misses        125      125              
- Partials       43       44       +1     
Flag Coverage Δ
unittests 91.87% <90.90%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tasks/dimensionality_reduction/methods/neuralee.py 84.78% <90.90%> (-2.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 457a12c...fd3204c. Read the comment docs.

Copy link
Copy Markdown
Member

@lazappi lazappi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks fine to me

@scottgigante-immunai scottgigante-immunai merged commit f74588c into openproblems-bio:main May 16, 2022
@scottgigante-immunai
Copy link
Copy Markdown
Collaborator Author

Thanks!

@scottgigante-immunai scottgigante-immunai deleted the tests/neuralee_speedup branch June 14, 2022 21:12
rcannood pushed a commit that referenced this pull request Sep 4, 2024
* set maximize to false

* fix typo

* refactor mse

* refactor true_features

* undo mse changes
rcannood pushed a commit that referenced this pull request Sep 4, 2024
* set maximize to false

* fix typo

* refactor mse

* refactor true_features

* undo mse changes

Former-commit-id: 0891a3c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants