set maxit on neuralee#403
Merged
scottgigante-immunai merged 1 commit intoopenproblems-bio:mainfrom May 16, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #403 +/- ##
==========================================
- Coverage 91.91% 91.87% -0.05%
==========================================
Files 89 89
Lines 2079 2079
Branches 119 120 +1
==========================================
- Hits 1911 1910 -1
Misses 125 125
- Partials 43 44 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
lazappi
approved these changes
May 16, 2022
Member
lazappi
left a comment
There was a problem hiding this comment.
I think this looks fine to me
Collaborator
Author
|
Thanks! |
rcannood
pushed a commit
that referenced
this pull request
Sep 4, 2024
* set maximize to false * fix typo * refactor mse * refactor true_features * undo mse changes
rcannood
pushed a commit
that referenced
this pull request
Sep 4, 2024
* set maximize to false * fix typo * refactor mse * refactor true_features * undo mse changes Former-commit-id: 0891a3c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NeuralEE takes ~10 minutes on test datasets. This should speed it up.
Submission type
Testing
Submission guidelines
PR review checklist
This PR will be evaluated on the basis of the following checks:
__init__.pyand were tested in the pipeline