Skip to content

Add processed spatial data aggregation and quality metrics#89

Merged
LouisK92 merged 7 commits intomainfrom
sp_agg_and_qmetrics
Oct 18, 2025
Merged

Add processed spatial data aggregation and quality metrics#89
LouisK92 merged 7 commits intomainfrom
sp_agg_and_qmetrics

Conversation

@LouisK92
Copy link
Copy Markdown
Contributor

@LouisK92 LouisK92 commented Oct 9, 2025

Some todos:

  • Update the generation of the test data as the aggregated processed spatial data is needed

@LouisK92 LouisK92 changed the title Add component for aggregating processed spatial data Add processed spatial data aggregation and quality metrics Oct 9, 2025
@LouisK92
Copy link
Copy Markdown
Contributor Author

Points to clarify:

  • How to merge the results from the quality metrics with the results of the metrics?
  • In this context. Maybe no problem, but think about: How to handle the case that for the similarity metrics we have control methods expr_corr_and_control_ch = expr_corr_ch.mix(control_ch) which wouldn't be the case for the quality metrics. (Currently quality metrics also don't need control methods imo, but could be that we need some additional control methods in the future)
  • How to write the output output_agg_spatial_data generated in the agg_spatial_data_ch to the final workflow output directory? And how to introduce a flag to make this optional (for large runs we don't want to generate endless of large files)

]
}
)

Copy link
Copy Markdown
Member

@lazappi lazappi Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to mix in the quality_metrics_ch here. Something like (approximate syntax):

Suggested change
// Add quality metrics
.mix(quality_metrics_ch)

This would create add the quality metrics into the channel in no particular order, the post processing can then be applied to all of the metric outputs.

Alternatively (or if this doesn't work), you could add the post-processing blocks to the quality_metrics_ch and then mix the two channels at the end when creating output_ch. This means repeating a bunch of code though.

@LouisK92 LouisK92 marked this pull request as ready for review October 18, 2025 21:53
@LouisK92 LouisK92 merged commit 053663a into main Oct 18, 2025
2 of 3 checks passed
@LouisK92 LouisK92 deleted the sp_agg_and_qmetrics branch October 18, 2025 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants