Add processed spatial data aggregation and quality metrics#89
Merged
Conversation
Contributor
Author
|
Points to clarify:
|
lazappi
reviewed
Oct 14, 2025
| ] | ||
| } | ||
| ) | ||
|
|
Member
There was a problem hiding this comment.
I think you want to mix in the quality_metrics_ch here. Something like (approximate syntax):
Suggested change
| // Add quality metrics | |
| .mix(quality_metrics_ch) |
This would create add the quality metrics into the channel in no particular order, the post processing can then be applied to all of the metric outputs.
Alternatively (or if this doesn't work), you could add the post-processing blocks to the quality_metrics_ch and then mix the two channels at the end when creating output_ch. This means repeating a bunch of code though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some todos: