generated from openproblems-bio/task_template
-
Notifications
You must be signed in to change notification settings - Fork 2
Add method: CellMapper #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rcannood
merged 11 commits into
openproblems-bio:main
from
quadbio:feature/no-ref/cellmapper
Aug 7, 2025
Merged
Add method: CellMapper #10
rcannood
merged 11 commits into
openproblems-bio:main
from
quadbio:feature/no-ref/cellmapper
Aug 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazappi
reviewed
Aug 6, 2025
lazappi
approved these changes
Aug 7, 2025
Member
lazappi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rcannood Anything else you want to check?
Member
|
No, LGTM! :) |
Contributor
Author
|
Amazing, thank you! I forgot to add myself as a contributer, I'll do this next time when I need to fix/update something. |
rcannood
added a commit
that referenced
this pull request
Aug 8, 2025
rcannood
added a commit
that referenced
this pull request
Aug 8, 2025
* Minor improvements to repo * update changelog * add marius as author (related to #10) * remove generic viash schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR includes CellMapper for modality prediction, see the CellMapper docs for more infos: https://cellmapper.readthedocs.io/en/latest/
It includes two variants that differ in how the shared latent space is computed between train and test datasets in modality 1:
The rest happens in CellMapper and is modality-agnostic. We construct a k-NN graph given some kernel function and map expression in modality 2 from train to test data.
Currently, running
viash test src/methods/cellmapper_scvi/config.vsh.yamlfails because myutils.pyfile isn't detected, that's because I don't know how to provide theresources_dirpath inmeta. Currently, I do:but that doesn't work locally. I've also looked around a bit what other methods do and tried different variants but could not get it to work. I would appreciate some input here how I could fix this. Thanks in advance!
Running the scripts for both variants and different parameter combinations as simple Python scripts works locally.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!