Fix issues with adding the units and long name to output wind fields#157
Merged
rcjackson merged 3 commits intoopenradar:mainfrom Apr 8, 2026
Merged
Fix issues with adding the units and long name to output wind fields#157rcjackson merged 3 commits intoopenradar:mainfrom
rcjackson merged 3 commits intoopenradar:mainfrom
Conversation
…elds The u, v, w DataArrays returned by get_dd_wind_field were missing the 'units' attribute entirely. Also, u_field and v_field had their long_name values swapped (u is zonal, v is meridional). Fixed in both the scipy and tensorflow output paths. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 69.21% 69.32% +0.11%
==========================================
Files 32 32
Lines 5217 5223 +6
==========================================
+ Hits 3611 3621 +10
+ Misses 1606 1602 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the version to 2.4.1. In addition, the output wind fields now have their units and long_name attributes.