Fixed owner filtering, DicomTask reset/delete views, and DICOM Explor…#236
Merged
medihack merged 2 commits intoopenradx:mainfrom Sep 23, 2025
Merged
Fixed owner filtering, DicomTask reset/delete views, and DICOM Explor…#236medihack merged 2 commits intoopenradx:mainfrom
medihack merged 2 commits intoopenradx:mainfrom
Conversation
medihack
approved these changes
Sep 23, 2025
samuelvkwong
pushed a commit
to samuelvkwong/adit
that referenced
this pull request
Oct 9, 2025
…er bugs (openradx#236) Co-authored-by: mhumzaarain <smarai@uni-bonn.de> Co-authored-by: Kai Schlamp <kai.schlamp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix DicomTask owner filtering, reset/delete views, and DICOM Explorer URL & query bugs
Description
This PR addresses multiple related issues in the task and DICOM Explorer modules:
1. Fix DicomTask owner filtering
DicomTaskmodel does not have a directownerfield; the owner exists ontask.job.filter(owner=self.request.user), causingFieldError.filter(job__owner=self.request.user).2. Fix DicomTaskResetView and DicomTaskDeleteView
PENDINGbut queued without refreshing from the DB, causing a status mismatch.queue_pending_task().ownerfield.job__ownerto respectis_deletablechecks.test_task_reset_viewandtest_task_delete_view.3. Fix DICOM Explorer server query bug: remove non-existent 'accesses_source' filter when querying DicomServer.