Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the CLI from argparse to typer, providing better type hints and modern CLI patterns. The change simplifies the command registration process by replacing manual argument parsing with typer's decorator-based approach.
Key changes:
- Replaced argparse with typer for CLI implementation
- Updated dependencies to include typer and remove argcomplete
- Simplified command registration using typer decorators
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updated dependencies to include typer, removed argcomplete, and changed CLI entry point |
| cli.py | Complete rewrite using typer instead of argparse with decorator-based command registration |
| .devcontainer/post-create.sh | Updated shell completion setup to use typer's built-in completion |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+5
to
+36
| from adit_radis_shared.cli import commands | ||
| from adit_radis_shared.cli import helper as cli_helper | ||
| from adit_radis_shared.cli import parsers | ||
| from adit_radis_shared.cli.setup import setup_root_parser | ||
|
|
||
| app = typer.Typer( | ||
| context_settings={"help_option_names": ["-h", "--help"]}, | ||
| no_args_is_help=True, | ||
| ) | ||
|
|
||
| app.command()(commands.init_workspace) | ||
| app.command()(commands.randomize_env_secrets) | ||
| app.command()(commands.compose_build) | ||
| app.command()(commands.compose_pull) | ||
| app.command()(commands.compose_up) | ||
| app.command()(commands.compose_down) | ||
| app.command()(commands.stack_deploy) | ||
| app.command()(commands.stack_rm) | ||
| app.command()(commands.lint) | ||
| app.command()(commands.format_code) | ||
| app.command()(commands.test) | ||
| app.command()(commands.shell) | ||
| app.command()(commands.show_outdated) | ||
| app.command()(commands.db_backup) | ||
| app.command()(commands.db_restore) | ||
| app.command()(commands.generate_auth_token) | ||
| app.command()(commands.generate_secure_password) | ||
| app.command()(commands.generate_django_secret_key) | ||
| app.command()(commands.generate_certificate_chain) | ||
| app.command()(commands.generate_certificate_files) | ||
| app.command()(commands.upgrade_postgres_volume) | ||
| app.command()(commands.try_github_actions) | ||
|
|
||
|
|
There was a problem hiding this comment.
The import assumes that all commands in the shared library are compatible with typer. Verify that the imported commands module provides typer-compatible functions, as the previous argparse-based implementation may have different function signatures.
samuelvkwong
pushed a commit
to samuelvkwong/adit
that referenced
this pull request
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.