Conversation
…xplorer, and selective transfer functionalities
…nd selective transfer to remove redundant docstrings for improved readability
Co-authored-by: Kai Schlamp <kai.schlamp@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive smoke tests for views across multiple Django applications to ensure basic functionality of HTTP endpoints.
- Adds smoke tests for selective transfer, batch transfer, batch query, and dicom explorer views
- Implements ordering of job query results by creation date in descending order
- Adds handling for jobs with no tasks in the post-processing logic
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| adit/selective_transfer/tests/test_selective_transfer.py | Adds smoke tests for all selective transfer views including job and task CRUD operations |
| adit/batch_transfer/tests/test_batch_transfer.py | Adds smoke tests for batch transfer job and task views with proper permissions |
| adit/batch_query/tests/test_batch_query.py | Adds smoke tests for batch query views including results and download functionality |
| adit/dicom_explorer/tests/test_dicom_explorer.py | Adds smoke tests for dicom explorer form view with and without server redirect |
| adit/core/tests/test_dicom_nodes.py | Comprehensive unit tests for DicomNode models and related functionality |
| adit/core/tests/test_dicom_job_task.py | Unit tests for DicomJob and DicomTask model behavior and properties |
| adit/core/views.py | Adds ordering by creation date to job list view queries |
| adit/core/models.py | Adds handling for jobs with no tasks in post_process method |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
medihack
changed the title
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
samuelvkwong
pushed a commit
that referenced
this pull request
Oct 15, 2025
* Add comprehensive test cases for batch query, batch transfer, DICOM explorer, and selective transfer functionalities * Remove unused task creation in batch query and selective transfer tests * Refactor test cases in batch query, batch transfer, DICOM explorer, and selective transfer to remove redundant docstrings for improved readability * Add unit tests for DICOM job and node functionalities (#237) Co-authored-by: Kai Schlamp <kai.schlamp@gmail.com> * Correct expected HTTP status in test_batch_query_job_delete_view * Fix some tests * Remove some flaky dicom explorer tests * Update adit/batch_query/tests/test_batch_query.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Rename some tests and fix small issues --------- Co-authored-by: mhumzaarain <smarai@uni-bonn.de> Co-authored-by: Muhammad Humza Arain <muhammadhumza1000@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.