Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CLI tool from using argparse to using typer for command line interface management. The change modernizes the CLI implementation by replacing the traditional argparse-based approach with typer's more declarative and type-safe approach.
- Replaced argparse with typer for CLI command handling
- Updated dependency configuration to include typer and remove argcomplete
- Migrated command registration from manual parser setup to typer decorators
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pyproject.toml | Updated dependencies to include typer, removed argcomplete, updated shared library version, and changed CLI entry point |
| cli.py | Complete rewrite from argparse to typer, converting functions to typer commands with proper type annotations |
| .devcontainer/post-create.sh | Updated shell completion setup to use typer's completion instead of argcomplete |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| profiles = [*profile, "gpu", "cpu"] | ||
| commands.compose_down(cleanup=cleanup, profile=profiles, **kwargs) | ||
|
|
||
| commands.compose_down(profile=profiles, extra_args=extra_args) |
There was a problem hiding this comment.
The compose_down function call is missing the cleanup parameter that was present in the original argparse version. This may cause different behavior compared to the previous implementation.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| def compose_down( | ||
| profile: Annotated[ | ||
| list[str] | None, typer.Option(help="Docker compose profile(s) to use") | ||
| ] = None, | ||
| extra_args: Annotated[ | ||
| list[str] | None, typer.Argument(help="Extra arguments (after '--')") | ||
| ] = None, | ||
| ): |
There was a problem hiding this comment.
The compose_down function is missing the cleanup parameter that was available in the original argparse implementation. This removes functionality that users may depend on.
1 participant
No description provided.