Skip to content

Conversation

@sweiland-openrails
Copy link
Contributor

@sweiland-openrails sweiland-openrails commented Jan 7, 2024

sweiland-openrails added a commit to sweiland-openrails/openrails that referenced this pull request Jan 7, 2024
schema.json Outdated
"start": {
"type": "object",
"required": [
"locomotive"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is only the "locomotive" a required field? On its own, that's not enough for a set of valid choices, I think.

Copy link
Contributor

@cjakeman cjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siebren,

It makes sense to have some default choices. I believe MSTS had an "Introductory Train Ride" as a starting point.

Can this be easily extended to a default Activity or a default Timetable too? (Not a priority just now.)

Best wishes,

Chris

@sweiland-openrails
Copy link
Contributor Author

Hi Siebren,

It makes sense to have some default choices. I believe MSTS had an "Introductory Train Ride" as a starting point.

Can this be easily extended to a default Activity or a default Timetable too? (Not a priority just now.)

Best wishes,

Chris

thanks for this reminder. I forgot to add them as required fields.

Siebren.

Copy link
Contributor

@cjakeman cjakeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Siebren,

This all looks good.

Approved with thanks,

Chris

@cjakeman cjakeman merged commit f07c9c7 into openrails:main Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants