Skip to content

Conversation

@wborn
Copy link
Member

@wborn wborn commented Feb 25, 2024

No description provided.

Added functionality to check for internet on start
Added SharedData in order to specify a specific offline activity in custom projects
@richturner richturner merged commit 449d7de into main Feb 28, 2024
@richturner richturner deleted the feature/start_offline_page branch February 28, 2024 14:57
@wborn
Copy link
Member Author

wborn commented Feb 28, 2024

Looks like the build fails with these changes.
Maybe @Miggets7 can have a look at it?

What helps is updating the compileSdk to 34 similar to ORLib:

However it then still complains about the missing CAMERA permission which was removed from ORLib:

  Lint found 1 errors, 5 warnings. First failure:
  
  /home/wouter/git/openremote/console-android/ORLib/src/main/java/io/openremote/orlib/ui/QrScannerActivity.kt:69: Error: Missing permissions required by CameraSource.start: android.permission.CAMERA [MissingPermission]
                          cameraSource!!.start(surfaceView!!.holder)
                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
     Explanation for issues of type "MissingPermission":
     This check scans through your code and libraries and looks at the APIs
     being used, and checks this against the set of permissions required to
     access those APIs. If the code using those APIs is called at runtime, then
     the program will crash.
  
     Furthermore, for permissions that are revocable (with targetSdkVersion 23),
     client code must also be prepared to handle the calls throwing an exception
     if the user rejects the request for permission at runtime.

See: https://github.com/openremote/console-android/actions/runs/8082425923

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants