Skip to content

Handle fact HttpApiManager initializer can now throw and review more … #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025
Merged

Handle fact HttpApiManager initializer can now throw and review more … #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions GenericApp/GenericApp/UI/WizardDomainViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,18 +91,18 @@ extension WizardDomainViewController: UITextFieldDelegate {
}

fileprivate func requestAppConfig(_ domain: String) {
configManager = ConfigManager(apiManagerFactory: { url in
HttpApiManager(baseUrl: url)
})

async {
do {
configManager = ConfigManager(apiManagerFactory: { url in
try HttpApiManager(baseUrl: url)
})

let state = try await configManager!.setDomain(domain: domain)
print("State \(state)")
switch state {
case .selectDomain:
// Something wrong, we just set the domain
let alertView = UIAlertController(title: "Error", message: "Error occurred getting app config. Check your input and try again", preferredStyle: .alert)
let alertView = UIAlertController(title: "Error", message: "Error occurred getting app config.\nCheck your input and try again.", preferredStyle: .alert)
alertView.addAction(UIAlertAction(title: "OK", style: .default, handler: nil))

self.present(alertView, animated: true, completion: nil)
Expand All @@ -113,8 +113,12 @@ extension WizardDomainViewController: UITextFieldDelegate {
case.complete:
self.performSegue(withIdentifier: Segues.goToWebView, sender: self)
}
} catch ApiManagerError.invalidUrl {
let alertView = UIAlertController(title: "Error", message: "Invalid domain.\nCheck your input and try again.", preferredStyle: .alert)
alertView.addAction(UIAlertAction(title: "OK", style: .default, handler: nil))
self.present(alertView, animated: true, completion: nil)
} catch {
let alertView = UIAlertController(title: "Error", message: "Error occurred getting app config. Check your input and try again", preferredStyle: .alert)
let alertView = UIAlertController(title: "Error", message: "Error occurred getting app config.\nCheck your input and try again.", preferredStyle: .alert)
alertView.addAction(UIAlertAction(title: "OK", style: .default, handler: nil))
self.present(alertView, animated: true, completion: nil)
}
Expand Down