Fix tests under SwiftPM (also when opening Xcode using Package.swift …#24
Merged
Fix tests under SwiftPM (also when opening Xcode using Package.swift …#24
Conversation
|
ebariaux
added a commit
that referenced
this pull request
Apr 8, 2026
* Add Swift Lint to build and required fix to get the project to build again * Add swiftlint configuration * Remove trailing blank lines * Fix linting violations, mostly spacing * Remove redundant break statements * Replace unused closure parameters with _ * Remove unnecessary parentheses in control statements * Fix syntax of Void returns * Fix line length violations * Don't init optionals to nil, that's the default * Removed unrequired parentheses * Fix identifier names length violations * Fix non-nil check * Proper syntax for dictionaries * Use for where syntax where appropriate * Also trigger workflow on PRs * Fix tests under SwiftPM (also when opening Xcode using Package.swift … (#24) * Fix tests under SwiftPM (also when opening Xcode using Package.swift file) * Simplified if structure * Add Swift Lint to build and required fix to get the project to build again * Add swiftlint configuration * Remove trailing blank lines * Fix linting violations, mostly spacing * Remove redundant break statements * Replace unused closure parameters with _ * Remove unnecessary parentheses in control statements * Fix syntax of Void returns * Fix line length violations * Don't init optionals to nil, that's the default * Removed unrequired parentheses * Fix identifier names length violations * Fix non-nil check * Proper syntax for dictionaries * Use for where syntax where appropriate * Also trigger workflow on PRs * Refactor method to reduce function body length * Remove non required function arguments * Simplify if expression * Refactor to avoid code duplication * Run linting as part of Xcode build, not as part of Package (to avoid dependencies in consuming projects) * Handle linting specifically for CI/CD, don't rely on Xcode build phase * Fixed linting violations * Review read-only property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…file)