ESPProvision/Add dynamic properties field to ORConfigChannelProtocol#28
Merged
dominiquekleeven merged 5 commits intoMay 27, 2026
Merged
Conversation
dominiquekleeven
changed the title
properties field to ORConfigChannelProtocolproperties field to ORConfigChannelProtocol
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Author
|
@ebariaux Requested review from you for this, fairly simple changes, tests pass. Codex+Claude assisted, since I am not that familiar with Swift/iOS. |
|
ebariaux
approved these changes
May 27, 2026
Contributor
ebariaux
left a comment
ebariaux
left a comment
There was a problem hiding this comment.
Just made a couple of minor improvements, ok to merge
dominiquekleeven
deleted the
enhancement/properties-field-orconfigchannelprotocol
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #29
Adds a
propertiesmap to theOpenRemoteConfigproto message and wires it through from the/rest/deviceREST response.This lets us forward additional config values (e.g. OTA URL/token) to the device during BLE provisioning when the backend supplies them.
The field is fully optional end-to-end. If the REST response omits properties, nothing is added on the wire.
Testing