Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CI/CD for extensions #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add CI/CD for extensions #38
Changes from all commits
87a95e1d31143501c8948938e98afedf5763f0e0fb7382fe17a4760c9927b733cc3642ae57ca9e52bc633817ddefe6148b4ba74e654de54979eea88d50771a258324a9d44e12589f8f9d077aa3f8db27b94314bc4841e68001e5b7e44e67306fef51dd16f0fe9b718dea41afeda795c1f88da483c4ec9d3c9e783File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job logs in to DockerHub and applies registry tags, but the build-push-action invocation sets
push: falsewhile also usingload: false; per docker/build-push-action semantics, that means the build result is not exported to the registry. On main pushes this leavesopenremote/manager:developunchanged, and the release image step has the same issue for version/latest tags.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This step is gated on
github.event_name == 'release', but this workflow is only configured forpush,pull_request, andworkflow_dispatchevents, so the manager image path never executes. As written, neither the tag-push run nor thegh workflow run ci_cd.yml --ref <tag>dispatch fromrelease.ymlcan satisfy this condition, so versioned/latestmanager images are never published.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workflow is only registered for
push,pull_request, andworkflow_dispatch, sogithub.event_nameis neverrelease; release tags configured at the top of this file arrive aspushevents. Becauserelease.ymlwas deleted in this commit, the manager image release step here and the Maven Sonatype publish step below are now skipped for every tagged release.Useful? React with 👍 / 👎.
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.