Improved logging for GOPACSHandler #8
Merged
Merged
Conversation
…tgoing flexOffer. Also use getConversationID to link messages.
wborn
reviewed
Feb 11, 2026
There was a problem hiding this comment.
Pull request overview
Improves observability of GOPACS UFTP message handling by logging conversation IDs and (at debug level) message contents to help correlate inbound/outbound traffic.
Changes:
- Update incoming/outgoing message logs to include
conversationIDand message type. - Add debug logs that serialize/log payload XML for outbound messages and raw inbound payload XML.
- Minor import cleanup (static import narrowed; import reordering).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Restore AGPL license header - Guard LOG.fine calls with LOG.isLoggable for XML payload logging - Add trailing newline at end of file
wborn
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added logging for showing the contents of the incoming message and outgoing flexOffer. Also use getConversationID to link messages.