Enable migrateTransitiveParent test for HttpClient 5 upgrade#126
Merged
Enable migrateTransitiveParent test for HttpClient 5 upgrade#126
Conversation
The test was disabled with a misleading message blaming DependencyInsight for not considering transitive parent dependencies. The actual issue was that the test had no Java source files in the child module, so AddDependency's onlyIfUsing gate never triggered. Add Java source files using old Apache HTTP types to the child module and simplify the POM assertion to use assertThat chain with .actual().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable the
@DisabledmigrateTransitiveParenttest inUpgradeApacheHttpClient5TestThe test was disabled blaming
DependencyInsightfor not considering transitive parent dependencies, but the actual issue was that the child module had no Java source files — soAddDependency'sonlyIfUsing: org.apache.http..*gate never triggeredAdd Java source files using old Apache HTTP types (
CloseableHttpClient,HttpClients) to the child module, with before/after expectations for the migrationSimplify POM assertion to use
assertThat(pom).contains(...).containsPattern(...).actual()patternRelates to Spring 6+ upgrades trigger migration to HttpClient 5 – how to deal with undeclared dependency on HttpClient 4? #35
Test plan
migrateTransitiveParenttest passesUpgradeApacheHttpClient5Testsuite passes