Pin empty MavenSettings in DependencyResolutionDiagnosticTest.maven()#178
Merged
Merged
Conversation
openrewrite/gh-automation#95 installs ~/.m2/settings.xml with `<mirrorOf>*</mirrorOf>` to route Maven through `artifactory.moderne.ninja` and avoid HTTP 429 from Maven Central. The mirror rewrites every repository request — including the test pom's deliberately-unreachable `<repository><url>https://nonexistent.moderne.io/maven2</url></repository>` — so the diagnostic recipe only sees the mirror and the local file cache. Neither Maven Central nor the test repo appear in the data table, and both assertions fail. Inject an explicit empty `MavenSettings` via `MavenExecutionContextView` (same pattern as `mavenSettingsWithMirrors`) so the recipe ignores `~/.m2/settings.xml` and sees the pom-declared repositories directly. The original three assertions are restored unchanged.
timtebeek
force-pushed
the
tim/fix-maven-diagnostic-mirror-friendly
branch
from
936f585 to
521170c
Compare
timtebeek
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openrewrite/gh-automation#95installs~/.m2/settings.xmlwith<mirrorOf>*</mirrorOf>to route Maven throughartifactory.moderne.ninja(avoiding HTTP 429 from Maven Central). The mirror rewrites every repository request — including the test pom's deliberately-unreachable<repository><url>https://nonexistent.moderne.io/maven2</url></repository>— so the diagnostic recipe only sees the mirror and the local file cache. Neither Maven Central nor the test repo appear in the data table; bothcontains(...)assertions fail.Inject an explicit empty
MavenSettingsviaMavenExecutionContextView(same pattern as the existingmavenSettingsWithMirrorstest) so the recipe ignores~/.m2/settings.xmland sees the pom-declared repositories directly. The original three assertions are restored unchanged.Failing CI run: https://github.com/openrewrite/rewrite-java-dependencies/actions/runs/26053770256
Test plan
./gradlew test --tests "org.openrewrite.java.dependencies.DependencyResolutionDiagnosticTest"passes locally