Cap Java version at 24 for Kotlin <2.3 in UpgradeToJava25#1035
Merged
Cap Java version at 24 for Kotlin <2.3 in UpgradeToJava25#1035
Conversation
Kotlin versions before 2.3 only support up to Java 24. When running UpgradeToJava25 on projects with kotlin-stdlib <2.3, the Java version is now set to 24 instead of 25.
timtebeek
commented
Mar 31, 2026
src/main/java/org/openrewrite/java/migrate/HasNoOldKotlinDependency.java
Outdated
Show resolved
Hide resolved
Replace HasNoOldKotlinDependency with ModuleHasDependency's invertMarking option for detecting projects without Kotlin <2.3.
Remove the intermediate UpgradeBuildToJava25 wrapper and reference UpgradeBuildToJava24ForOldKotlin and UpgradeBuildToJava25Default directly from UpgradeToJava25.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cap Java version at 24 when a project uses Kotlin <2.3 (which doesn't support Java 25)
Replace the single
UpgradeJavaVersion(25)call with two preconditioned recipes:UpgradeBuildToJava24— applies whenkotlin-stdlib <2.3is presentUpgradeBuildToJava25— applies otherwise (no Kotlin, or Kotlin >=2.3) viaModuleHasDependencywithinvertMarking: truePure YAML solution, no custom Java code needed
Fixes https://github.com/moderneinc/customer-requests/issues/2126
Test plan