Upgrade jakarta.annotation-api to 3.0.x in Jakarta EE 11 recipe#1042
Merged
Upgrade jakarta.annotation-api to 3.0.x in Jakarta EE 11 recipe#1042
Conversation
The UpdateJakartaPlatform11 recipe was missing the version upgrade for jakarta.annotation:jakarta.annotation-api to 3.0.x, which is the version specified by the Jakarta EE 11 platform BOM. Jakarta EE 10 already upgrades to 2.1.x via MigrationToJakarta10Apis. Also adds tests for JavaxAnnotationMigrationToJakartaAnnotation covering both the explicit dependency migration and the no-explicit-dependency scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jakarta.annotation:jakarta.annotation-api3.0.x version upgrade toUpdateJakartaPlatform11JavaxAnnotationMigrationToJakartaAnnotationProblem
The
UpdateJakartaPlatform11recipe upgradesjakarta.platformandjakarta.servlet.jsp-apibut was missing the upgrade forjakarta.annotation-apito 3.0.x. Jakarta EE 10 already handles the 2.1.x upgrade viaMigrationToJakarta10Apis, but EE 11 should bring it to 3.0.x per the Jakarta EE 11 platform BOM.A customer reported that after running a Java 21 + Jakarta EE migration, their POM had
jakarta.annotation-apiat an older version instead of 3.0.x.Solution
Added
UpgradeDependencyVersionforjakarta.annotation:jakarta.annotation-apiwithnewVersion: 3.0.xto theUpdateJakartaPlatform11recipe, following the same pattern as the existing entries.Also added
JavaxAnnotationMigrationToJakartaAnnotationTestwith two test cases covering explicit dependency migration and the no-explicit-dependency scenario.Test plan
JavaxAnnotationMigrationToJakartaAnnotationpassJakartaEE11Testpassesjakarta.*andjavax.*test suites pass with no regressions