Add explicit casts for visitor visit() return type#1049
Merged
Conversation
The `visit()` method on OpenRewrite visitors now returns `J` rather than the specific subtype. Add explicit casts at affected call sites: - `RefineSwitchCases` — cast to `J.Switch` - `IfElseIfConstructToSwitch` — cast to `J.Switch` - `LombokValueToRecord` — cast to `J.ClassDeclaration` - `RemoveEmbeddableId` — cast to `J.ClassDeclaration` Also fix `MoveAnnotationToArrayType` missing `@Nullable` import by adding `org.jspecify.annotations.Nullable` and adjusting type-use annotation placement.
…uctors test The core ChangeMethodTargetToStatic recipe now matches constructor calls with the wildcard pattern, incorrectly converting `new Modifier()` to `Modifier.Modifier()`. Pass instances as parameters instead to avoid triggering the constructor matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
visit()method on OpenRewrite visitors now returnsJrather than the specific subtypeJ.Switch,J.ClassDeclaration)@Nullableimport inMoveAnnotationToArrayType(addorg.jspecify.annotations.Nullable, adjust type-use annotation placement)Changed files
RefineSwitchCases.java— cast toJ.SwitchIfElseIfConstructToSwitch.java— cast toJ.SwitchLombokValueToRecord.java— cast toJ.ClassDeclarationRemoveEmbeddableId.java— cast toJ.ClassDeclarationMoveAnnotationToArrayType.java— add@Nullableimport, fix annotation placementTest plan
./gradlew compileJavapasses./gradlew test(running)