Skip to content

Use single visitor in UpgradeDockerImageVersion to eliminate 3000+ child recipes#1059

Closed
timtebeek wants to merge 1 commit intomainfrom
tim/shrink-docker-image-upgrade
Closed

Use single visitor in UpgradeDockerImageVersion to eliminate 3000+ child recipes#1059
timtebeek wants to merge 1 commit intomainfrom
tim/shrink-docker-image-upgrade

Conversation

@timtebeek
Copy link
Copy Markdown
Member

Summary

  • Replaces the cartesian enumeration of ChangeFrom child recipes (images × versions × OS suffixes = ~3,150 children) with a single DockerFrom visitor that dynamically parses the tag at visit time.
  • The visitor extracts the leading version number, preserves any dash-prefixed suffix (e.g. -jdk-alpine), and migrates deprecated images (openjdk, adoptopenjdk) to eclipse-temurin.
  • This dramatically shrinks the recipe tree without changing behavior — all existing tests pass unchanged.

Test plan

  • Existing UpgradeDockerImageVersionTest passes (parameterized tests covering deprecated image migration, suffix preservation, and current image tag updates)

…geFrom children

Replace the cartesian product of images × versions × OS suffixes with a
single DockerFrom visitor that dynamically parses the tag, preserves any
dash-prefixed suffix, and migrates deprecated images to eclipse-temurin.
@github-project-automation github-project-automation Bot moved this to In Progress in OpenRewrite Apr 14, 2026
@github-project-automation github-project-automation Bot moved this from In Progress to Done in OpenRewrite Apr 14, 2026
@timtebeek timtebeek deleted the tim/shrink-docker-image-upgrade branch April 14, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants