Support copyOf migration for Guava#1062
Merged
greg-at-moderne merged 2 commits intomainfrom Apr 16, 2026
Merged
Conversation
Contributor
|
Looking at the comments on (a previous attempt), would it have made more sense to have an |
timtebeek
approved these changes
Apr 15, 2026
Contributor
Author
To be honest, that was one of the options I have considered. But this looked like somewhat artificial exercise in OOP. |
Contributor
Author
|
Merging, we can always consider refaxtoring the code later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
Adding three new building recipes for No Guava recipe:
modelled after (or actually now sharing code with) the existing:
What's your motivation?
Immutable{Set|List|Map}.copyOf()calls with Java{Set|List|Map}.copyOf()calls #584