Skip var when reassignment relies on declared supertype#1078
Merged
Conversation
When a generic variable is declared as a supertype but initialized with a concrete subtype constructor or method, switching to `var` narrows the inferred type and breaks later reassignments. Detect reassignment within the enclosing method and skip the transformation in that case. Fixes #1077
The test's `2.1.\d+` regex matched `<johnzon.version>2.1.0</johnzon.version>` before reaching the jakarta.json-api dependency, so when jakarta.json-api was released as 2.1.3 the expected/actual diverged. Anchor the regex to the jakarta.json-api artifact. Also consolidate the `isReassigned` visitor to use `.reduce(...)` directly, matching the existing idiom in NullCheck and other recipes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect reassignments to a variable within its enclosing method via a new
DeclarationCheck.isReassignedhelper.In
UseVarForGenericsConstructorsandUseVarForGenericMethodInvocations, skip the transformation when the declared type differs from the initializer's concrete type and the variable is later reassigned, sincevarwould narrow the inferred type and break those reassignments.Adds a regression test mirroring the
Set<ConstantFact> currentFacts = new HashSet<>(...)case from the issue.Fixes Issue discovered on
src/test/java/org/openrewrite/analysis/dataflow/ForwardDataFlowAnalysisTest.javawithUseVarForGenericsConstructors#1077Test plan
./gradlew test --tests "org.openrewrite.java.migrate.lang.var.*"