Skip main migration when referenced as static API#1084
Merged
Conversation
Convert `MigrateMainMethodToInstanceMain` to a `ScanningRecipe` so it detects `Main.main(...)` invocations and `Main::main` references across all compilation units, not just the same file. Migrating the declaring class to `void main()` would otherwise leave call sites broken. Fixes #1083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Convert
MigrateMainMethodToInstanceMainto aScanningRecipeso it scans every compilation unit for references to a class'smain(String[])method, not only the file in which it's declared.Detect
Main.main(...)method invocations in addition toMain::mainmember references, and skip migrating classes whose static main is referenced anywhere.Add tests for static
maininvocations from another file and from the same file.Fixes MigrateMainMethodToInstanceMain changes main method referenced as static API #1083
Test plan
./gradlew :test --tests "org.openrewrite.java.migrate.lang.MigrateMainMethodToInstanceMainTest"