Skip Immutable*.copyOf rewrite when argument is not a Collection#1089
Merged
Conversation
`List.copyOf` and `Set.copyOf` only accept `Collection`, and `Map.copyOf` only accepts `Map`, while their Guava counterparts also accept `Iterable` and `Iterator`. Skip the rewrite when the argument type would not satisfy the JDK signature, to avoid producing code that fails to compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NoGuavaImmutable{List,Set,Map}CopyOfwere rewritingImmutable*.copyOf(Iterable)(andIterator) calls intoList.copyOf/Set.copyOf/Map.copyOf, but the JDK overloads only acceptCollection(orMap), producing code that fails to compile. The sharedAbstractNoGuavaImmutableOfnow skips the rewrite when the argument type is not assignable to the JDK target's parameter type. Added regression tests coveringIterable/Iteratorarguments for all three recipes.