Skip to content

Skip UseMapOf when put() argument is a null literal #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timtebeek merged 1 commit into from
May 11, 2026
Merged

Skip UseMapOf when put() argument is a null literal #1094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/org/openrewrite/java/migrate/util/UseMapOf.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,11 @@ public J visitNewClass(J.NewClass newClass, ExecutionContext ctx) {
return n;
}
J.MethodInvocation put = (J.MethodInvocation) stat;
for (Expression arg : put.getArguments()) {
if (J.Literal.isLiteralValue(arg, null)) {
return n;
}
}
args.addAll(put.getArguments());
if (useEntries) {
template.add("Map.entry(#{any()}, #{any()})");
Expand Down
42 changes: 42 additions & 0 deletions src/test/java/org/openrewrite/java/migrate/util/UseMapOfTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,48 @@ Map<String, Integer> values() {
);
}

@Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/1092")
@Test
void doNotChangeWhenNullValue() {
//language=java
rewriteRun(
java(
"""
import java.util.HashMap;
import java.util.Map;

class Test {
Map<String, String> m = new HashMap<>() {{
put("key", "value");
put("nullable", null);
}};
}
"""
)
);
}

@Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/1092")
@Test
void doNotChangeWhenNullKey() {
//language=java
rewriteRun(
java(
"""
import java.util.HashMap;
import java.util.Map;

class Test {
Map<String, String> m = new HashMap<>() {{
put(null, "value");
put("key", "other");
}};
}
"""
)
);
}

@Issue("https://github.com/openrewrite/rewrite-migrate-java/issues/566")
@Test
void changeDoubleBraceInitForNonStringTypes() {
Expand Down
Loading