Skip to content

Conversation

@Crustack
Copy link
Contributor

What's changed?

Do not replace Maps.newLinkedHashMapWithExpectedSize(capacity) with new LinkedHashMap(capacity) in the NoGuavaMapsNewLinkedHashMap recipe.

What's your motivation?

See #431 (comment)

Anything in particular you'd like reviewers to focus on?

Anyone you would like to review specifically?

Have you considered any alternatives or workarounds?

Any additional context

Checklist

  • I've added unit tests to cover both positive and negative cases
  • I've read and applied the recipe conventions and best practices
  • I've used the IntelliJ IDEA auto-formatter on affected files

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/migrate/maven/UpdateMavenProjectPropertyJavaVersion.java
    • lines 1-0

@Crustack
Copy link
Contributor Author

Some suggestions could not be made:

  • src/main/java/org/openrewrite/java/migrate/maven/UpdateMavenProjectPropertyJavaVersion.java

    • lines 1-0

@timtebeek is this related to my PR? Looks like there is a License header missing? https://github.com/openrewrite/rewrite-migrate-java/actions/runs/8330730650/job/22809320245?pr=432#step:5:780

@timtebeek
Copy link
Member

Looks like there was a push to main that circumvented this check, and broke things here. Should be fixed now.

I'm still out for another couple weeks, but colleagues should pick up the review while in our. Thanks again!

Copy link
Contributor

@knutwannheden knutwannheden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants