Also change Guava Predicate method name #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/java/migrate/guava/PreferJavaUtilPredicateTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/guava/PreferJavaUtilPredicateTest.java
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Added an additional
ChangeMethodNameand unit test toPreferJavaUtilPredicate.What's your motivation?
Fixes #435
Anything in particular you'd like reviewers to focus on?
ChangeMethodNamefor now ignores theNewClass, instead looking forClassDeclarationwhen trying to match the method pattern supplied, which therefor mismatches and fails to do the required replacement. This should probably be fixed upstream in rewrite-java.Have you considered any alternatives or workarounds?
We could add a dedicated recipe here for that replacement, but then any similar such change would need the same. It'd be easier if
ChangeMethodNamesupported this out of the box, especially when usingmatchOverrides.Any additional context
PreferJavaUtilPredicatedoes not change functional method {apply -> test} #435